firebase / firebase/firebase-admin-python

Fix typos and wrong types in remote_config.py

未關閉 適合新手
#957 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
api: remoteconfig
主要語言
Python
星號
1.2k
分支
359
平均合併
5 天 6 分鐘
30 天內合併 PR
2

描述

### [READ] Step 1: Are you in the right place?
This is a bug in the code of this repository (`firebase_admin/remote_config.py`).

---

### [REQUIRED] Step 2: Describe your environment

* Operating System version: Windows 11
* Firebase SDK version: 6.x (latest)
* Firebase Product: remote_config
* Python version: 3.11
* Pip version: 24.x

---

### [REQUIRED] Step 3: Describe the problem

#### Steps to reproduce:

In `firebase_admin/remote_config.py`, the method `evaluate_custom_signal_condition`
uses `{}` (empty dict) as the default fallback for string and list fields:

custom_signal_operator = custom_signal_condition.get('customSignalOperator') or {}
custom_signal_key = custom_signal_condition.get('customSignalKey') or {}
target_custom_signal_values = custom_signal_condition.get('targetCustomSignalValues') or {}

These should be `''` (string) and `[]` (list) respectively, as the fields are
not dicts. Using `{}` is semantically incorrect.

Also, `_Value.as_int()` has a wrong return type annotation `-> float` instead
of `-> int`.

#### Relevant Code:

```python
# Wrong defaults — should be '' and []
custom_signal_operator = custom_signal_condition.get('customSignalOperator') or {}
custom_signal_key = custom_signal_condition.get('customSignalKey') or {}
target_custom_signal_values = custom_signal_condition.get('targetCustomSignalValues') or {}

# Wrong return type annotation — should be -> int
def as_int(self) -> float:
"""Returns the value as a number."""

貢獻指南

開啟貢獻指南

研究方向

Start in firebase_admin/remote_config.py, reading evaluate_custom_signal_condition and _Value.as_int() along with nearby type handling. Verify the fallback values and return annotation against the issue, then run the repository's relevant remote-config tests if available; done means the defaults and annotation match their field types without regressions.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
api, backend
Issue 類型
缺陷
難度
2/5
預估耗時
1-3 小時
活躍度
冷清
描述清晰度
描述清楚
新手友好度
75/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。