firebase / firebase/firebase-admin-python
Fix typos and wrong types in remote_config.py
- Linguagem predominante
- Python
- Estrelas
- 1.2k
- Forks
- 359
- Merge médio
- 5d 6min
- PRs com merge (30d)
- 2
Descrição
### [READ] Step 1: Are you in the right place?
This is a bug in the code of this repository (`firebase_admin/remote_config.py`).
---
### [REQUIRED] Step 2: Describe your environment
* Operating System version: Windows 11
* Firebase SDK version: 6.x (latest)
* Firebase Product: remote_config
* Python version: 3.11
* Pip version: 24.x
---
### [REQUIRED] Step 3: Describe the problem
#### Steps to reproduce:
In `firebase_admin/remote_config.py`, the method `evaluate_custom_signal_condition`
uses `{}` (empty dict) as the default fallback for string and list fields:
custom_signal_operator = custom_signal_condition.get('customSignalOperator') or {}
custom_signal_key = custom_signal_condition.get('customSignalKey') or {}
target_custom_signal_values = custom_signal_condition.get('targetCustomSignalValues') or {}
These should be `''` (string) and `[]` (list) respectively, as the fields are
not dicts. Using `{}` is semantically incorrect.
Also, `_Value.as_int()` has a wrong return type annotation `-> float` instead
of `-> int`.
#### Relevant Code:
```python
# Wrong defaults — should be '' and []
custom_signal_operator = custom_signal_condition.get('customSignalOperator') or {}
custom_signal_key = custom_signal_condition.get('customSignalKey') or {}
target_custom_signal_values = custom_signal_condition.get('targetCustomSignalValues') or {}
# Wrong return type annotation — should be -> int
def as_int(self) -> float:
"""Returns the value as a number."""
Guia de contribuição
Direção de pesquisa
Start in firebase_admin/remote_config.py, reading evaluate_custom_signal_condition and _Value.as_int() along with nearby type handling. Verify the fallback values and return annotation against the issue, then run the repository's relevant remote-config tests if available; done means the defaults and annotation match their field types without regressions.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- python
- Domínio
- api, backend
- Tipo de issue
- Bug
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Pouca atividade
- Clareza
- Claramente especificada
- Facilidade para iniciantes
- 75/100