firebase / firebase/firebase-admin-java

Not meaningful timeout default values leading to hanging requests

Aperta
#901 1 commento 2 reazioni 0 assegnatari Vedi su GitHub
needs-triage
Lingua principale
Java
Stelle
620
Fork
305
Merge medio
3h 23m
PR unite (30g)
1

Descrizione

### [REQUIRED] Step 2: Describe your environment

* Operating System version: MacOS Sonoma 14.1.1
* Firebase SDK version: v9.2.0
* Library version: _____
* Firebase Product: Firebase Cloud Messaging

### [REQUIRED] Step 3: Describe the problem
Sometimes the Google Server do not respond (like described in #850 ). However, the default values to read timeout and connect timeout are "0" because they are default initialized with 0 in the FirebaseOptions. So these requests hang for infinite time.

#### Steps to reproduce:
Send a message via FCM and the SDK. If Google does not respond, there is not timeout.

#### Fix:
Provide meaningful default values like 20s. This is the default in the Google HTTP Client (com.google.api.client.http.HttpRequest#readTimeout).

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by tracing how FirebaseOptions initializes the read and connect timeout values used for Firebase Cloud Messaging requests, and compare them with the Google HTTP Client defaults. Done means requests no longer hang indefinitely when Google does not respond and tests cover the chosen default timeout behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
networking
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.