firebase / firebase/firebase-admin-java

Not meaningful timeout default values leading to hanging requests

Offen
#901 1 Kommentar 2 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
needs-triage
Vorherrschende Sprache
Java
Sterne
620
Forks
305
Ø Merge
3 Std. 23 Min.
Gemergte PRs (30 T.)
1

Beschreibung

### [REQUIRED] Step 2: Describe your environment

* Operating System version: MacOS Sonoma 14.1.1
* Firebase SDK version: v9.2.0
* Library version: _____
* Firebase Product: Firebase Cloud Messaging

### [REQUIRED] Step 3: Describe the problem
Sometimes the Google Server do not respond (like described in #850 ). However, the default values to read timeout and connect timeout are "0" because they are default initialized with 0 in the FirebaseOptions. So these requests hang for infinite time.

#### Steps to reproduce:
Send a message via FCM and the SDK. If Google does not respond, there is not timeout.

#### Fix:
Provide meaningful default values like 20s. This is the default in the Google HTTP Client (com.google.api.client.http.HttpRequest#readTimeout).

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by tracing how FirebaseOptions initializes the read and connect timeout values used for Firebase Cloud Messaging requests, and compare them with the Google HTTP Client defaults. Done means requests no longer hang indefinitely when Google does not respond and tests cover the chosen default timeout behavior.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
java
Bereich
networking
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
35/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.