firebase / firebase/firebase-admin-java

Fixed an error message when sending more than 500 pieces

未关闭
#827 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
needs-triage
主要语言
Java
星标
620
派生
305
平均合并
3 小时 23 分钟
30 天内合并 PR
1

描述

I need a fix for the error message that shows when over 500 messages occur. Currently, the message is showing as 500 inclusive, which should be changed to excess.

```java
private CallableOperation sendAllOp(
final List messages, final boolean dryRun) {

final List immutableMessages = ImmutableList.copyOf(messages);
checkArgument(!immutableMessages.isEmpty(), "messages list must not be empty");
checkArgument(immutableMessages.size() <= 500,
"messages list must not contain more than 500 elements");
final FirebaseMessagingClient messagingClient = getMessagingClient();
return new CallableOperation() {
@Override
protected BatchResponse execute() throws FirebaseMessagingException {
return messagingClient.sendAll(messages, dryRun);
}
};
}
```

贡献指南

打开贡献指南

调研方向

Start at the sendAllOp method shown in the issue and inspect the validation message for lists larger than 500 elements. Verify the wording for an input exceeding the limit and confirm that the existing boundary of 500 remains valid.

由索引模型根据 Issue 内容生成。

评估

技术栈
java
领域
api
Issue 类型
缺陷
难度
1/5
预计耗时
1 小时以内
活跃度
停滞
描述清晰度
描述清楚
新手友好度
52/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。