firebase / firebase/firebase-admin-java

Fixed an error message when sending more than 500 pieces

Open
#827 1 comment 0 reactions 0 assignees View on GitHub
needs-triage
Dominant language
Java
Stars
620
Forks
305
Avg merge
3h 23m
Merged PRs (30d)
1

Description

I need a fix for the error message that shows when over 500 messages occur. Currently, the message is showing as 500 inclusive, which should be changed to excess.

```java
private CallableOperation sendAllOp(
final List messages, final boolean dryRun) {

final List immutableMessages = ImmutableList.copyOf(messages);
checkArgument(!immutableMessages.isEmpty(), "messages list must not be empty");
checkArgument(immutableMessages.size() <= 500,
"messages list must not contain more than 500 elements");
final FirebaseMessagingClient messagingClient = getMessagingClient();
return new CallableOperation() {
@Override
protected BatchResponse execute() throws FirebaseMessagingException {
return messagingClient.sendAll(messages, dryRun);
}
};
}
```

Contributor guide

Open the contributing guide

Research direction

Start at the sendAllOp method shown in the issue and inspect the validation message for lists larger than 500 elements. Verify the wording for an input exceeding the limit and confirm that the existing boundary of 500 remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.