felixge / felixge/node-sandboxed-module

locals does not appear to set variable inside the module

未关闭
#45 5 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
343
派生
41
PR 合并指标
30 天内没有已合并 PR

描述

I'm trying to get locals working and suspect I'm doing something wrong as my scenario feels like it should be very basic.

In this simplified scenario, I have a test that should inject a local variable into my module which should override an existing variable. I then have an assertion that verifies the value was set.

mod.js looks like this

```
var foo = 'bar';

exports.getFoo = function(key){
return foo;
};
```

and modTests.js looks like this

```
var SandboxedModule = require('sandboxed-module');

var mod = SandboxedModule.require('../lib/mod', {
locals: { foo: 'baz' }
});

describe('mod', function(){
it('should have value bar', function(){
mod.getFoo().should.eql('baz');
});
});
```

When I run the tests, I get an error that the function returns undefined. Not sure whether I'm doing something wrong here (I suspect so, as this seems like a really basic scenario) or if there's an issue in the code (I did step into it a bit, but it appeared that the local was at least collected from the options).

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。