felixge / felixge/node-sandboxed-module

locals does not appear to set variable inside the module

Offen
#45 5 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
343
Forks
41
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

I'm trying to get locals working and suspect I'm doing something wrong as my scenario feels like it should be very basic.

In this simplified scenario, I have a test that should inject a local variable into my module which should override an existing variable. I then have an assertion that verifies the value was set.

mod.js looks like this

```
var foo = 'bar';

exports.getFoo = function(key){
return foo;
};
```

and modTests.js looks like this

```
var SandboxedModule = require('sandboxed-module');

var mod = SandboxedModule.require('../lib/mod', {
locals: { foo: 'baz' }
});

describe('mod', function(){
it('should have value bar', function(){
mod.getFoo().should.eql('baz');
});
});
```

When I run the tests, I get an error that the function returns undefined. Not sure whether I'm doing something wrong here (I suspect so, as this seems like a really basic scenario) or if there's an issue in the code (I did step into it a bit, but it appeared that the local was at least collected from the options).

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.