felangel / felangel/mason

Consider renaming Logger

Open
#584 8 comments 2 reactions 1 assignee Claimed by @felangel View on GitHub
enhancement candidate question waiting for response
Dominant language
Dart
Stars
1.1k
Forks
113
PR merge metrics
No merged PRs in 30d

Description

Mason might have too many users already to do anything about this , but I thought I'd point this out.

The term "Logger" appears to be used within the context of hooks to interact with a user. This is a very confusing name. I don't think I've ever seen the term "logger" applied to user interaction. It would never have occurred to me to look at the `Logger` API to control user input, except that I saw some other source code that was using it for that purpose.

Typically, logging is the passive accumulation of information during execution. Logs might print to stdout, or maybe not. But either way, it's information gathering.

User interaction is a two-way exchange with lots of blocking in between. The goals of this user interaction is very different than that of logging, and loggers would never dream of blocking execution to wait for a response.

You might consider adjusting the associated API names, so that Mason developers know where to go for traditional logging, and where to go for a console-based user interface.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.