Consider renaming didSubscribe to didMount
Aperta
good first issue
Hacktoberfest
help wanted
- Lingua principale
- TypeScript
- Stelle
- 929
- Fork
- 27
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Brilliant package. I really like this.
Please consider renaming didSubscribe to didMount so that it is crystal clear what this is doing.
I'm not sure it is clear immediately to users how this aligns to React or Vue. The fact that didSubscribe isn't handled server side means that 'For handling side-effects upon first subscription.' isn't true in every circumstance.
The added advantage is that new developers who have not seen proppy, but have used recompose should immediately understand what 'didMount' does.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.