Consider renaming didSubscribe to didMount
Ouverte
good first issue
Hacktoberfest
help wanted
- Langage dominant
- TypeScript
- Étoiles
- 929
- Forks
- 27
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Brilliant package. I really like this.
Please consider renaming didSubscribe to didMount so that it is crystal clear what this is doing.
I'm not sure it is clear immediately to users how this aligns to React or Vue. The fact that didSubscribe isn't handled server side means that 'For handling side-effects upon first subscription.' isn't true in every circumstance.
The added advantage is that new developers who have not seen proppy, but have used recompose should immediately understand what 'didMount' does.
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.