facebook / facebook/zstd

Building zstd on WinXP with MinGW

Aperta
#1,811 9 commenti 4 reazioni 1 assegnatario Rivendicata da @Cyan4973 Vedi su GitHub
Portability
Lingua principale
C
Stelle
27.9k
Fork
2.6k
Merge medio
1g 3h
PR unite (30g)
8

Descrizione

I tried to build zstd on WinXP using MinGW-W64 7.3.0. After minor changes in CMakeLists everything seemed to be fine. But when I tried to run zstd.exe, it silently crashed. After some investigation I found out that kernel32.dll lacks InitializeConditionVariable() and three other functions related to condition variables. These functions are supported on Vista or higher. Because XP is obsolete, I do not expect a sophisticated solution, but a simple warning when zstd is built on XP would be nice.

BTW. In case of MinGW and XP thread safety is quite simple to achive – one should switch to pthreads by modyfying one line in threading.[ch]:
`#if defined(ZSTD_MULTITHREAD) && defined(_WIN32)`
to
`#if defined(ZSTD_MULTITHREAD) && defined(_WIN32) && !defined(__MINGW32__)`

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.