facebook / facebook/zstd

Building zstd on WinXP with MinGW

Abierto
#1,811 9 comentarios 4 reacciones 1 asignado Reclamado por @Cyan4973 Ver en GitHub
Portability
Lenguaje dominante
C
Estrellas
27.9k
Forks
2.6k
Merge medio
1 d 3 h
PR fusionados (30 d)
8

Descripción

I tried to build zstd on WinXP using MinGW-W64 7.3.0. After minor changes in CMakeLists everything seemed to be fine. But when I tried to run zstd.exe, it silently crashed. After some investigation I found out that kernel32.dll lacks InitializeConditionVariable() and three other functions related to condition variables. These functions are supported on Vista or higher. Because XP is obsolete, I do not expect a sophisticated solution, but a simple warning when zstd is built on XP would be nice.

BTW. In case of MinGW and XP thread safety is quite simple to achive – one should switch to pthreads by modyfying one line in threading.[ch]:
`#if defined(ZSTD_MULTITHREAD) && defined(_WIN32)`
to
`#if defined(ZSTD_MULTITHREAD) && defined(_WIN32) && !defined(__MINGW32__)`

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.