facebook / facebook/hhvm

Path to the configuration file missing in the status verbose output

オープン
#4,574 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
probably easy
主要言語
C++
スター
18.7k
フォーク
3.1k
平均マージ
1時間 47分
マージ済み PR(30日)
2

説明

When running framework tests in verbose mode, in some places the command of the test is returned.
Unfortunately, sometimes it doesn't contain a path to the xml configuration file
e.g. see below. The path to the file should be between "-c" and "--filter"

```
RUN TEST FILE: cd /home/vagrant/dev/hhvm/hphp/test/frameworks/framework_downloads/typo3/typo3/sysext/core/Build && export TYPO3_PATH_WEB="/home/vagrant/dev/hhvm/hphp/test/frameworks/framework_downloads/typo3" && /home/vagrant/dev/hhvm/hphp/test/frameworks/../../hhvm/hhvm -v Repo.Local.Mode=-- -v Repo.Central.Path=/tmp/framework-testw1vYu6 --config /home/vagrant/dev/hhvm/hphp/test/frameworks/php.ini /home/vagrant/dev/hhvm/hphp/test/frameworks/framework_class_overrides/../framework_downloads/typo3/bin/phpunit --debug -c --filter 'TYPO3\\CMS\\Core\\Tests\\Unit\\Utility\\GeneralUtilityTest::formatSizeTranslatesBytesToHigherOrderRepresentation with data set "Label for gigabytes can be exchanged"'
```

I found out that the path is not included when outputing the data from line 238, and 222 of Runner.php

However the config file is present correctly at the beginning of the output
e.g.

```
Beginning the unit tests.....
Command: export TYPO3_PATH_WEB="/home/vagrant/dev/hhvm/hphp/test/frameworks/framework_downloads/typo3" && /home/vagrant/dev/hhvm/hphp/test/frameworks/../../hhvm/hhvm -v Repo.Local.Mode=-- -v Repo.Central.Path=/tmp/framework-testw1vYu6 --config /home/vagrant/dev/hhvm/hphp/test/frameworks/php.ini /home/vagrant/dev/hhvm/hphp/test/frameworks/framework_class_overrides/../framework_downloads/typo3/bin/phpunit --debug -c /home/vagrant/dev/hhvm/hphp/test/frameworks/framework_downloads/typo3/typo3/sysext/core/Build/HHVMUnitTests.xml 2>&1
```

and also after I placed debug message at the beginning of getTestRunStr()

```
verbose("Command2: ".$this->actual_test_command."\n");
```

I've got correct results every time.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。