facebook / facebook/TestSlide

Add `--fail-if-warning`

Ouverte
#195 4 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
enhancement Hacktoberfest help wanted
Langage dominant
Python
Étoiles
149
Forks
62
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Let's add an option `--fail-if-warning`, which'll look over issued warnings during test execution and fail them if warning issued. This can probably be done easily by patching Python's warning method and checking if it was called.

I see 3 cases to check for warnings:

1 - When importing test modules.
2 - When running individual tests.
3 - On shutdown.

For 1 & 2, this should be easy, not sure about 3.

An important feature of this, is to allow include / exclude paths to accept / ignore warnings. Eg: if a warning came from a third party library, there's sometimes little one can do, and we should ignore it. If warning came from the code being tested, it should surface.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.