facebook / facebook/TestSlide

Add `--fail-if-warning`

Open
#195 4 comments 2 reactions 0 assignees View on GitHub
enhancement Hacktoberfest help wanted
Dominant language
Python
Stars
149
Forks
62
PR merge metrics
No merged PRs in 30d

Description

Let's add an option `--fail-if-warning`, which'll look over issued warnings during test execution and fail them if warning issued. This can probably be done easily by patching Python's warning method and checking if it was called.

I see 3 cases to check for warnings:

1 - When importing test modules.
2 - When running individual tests.
3 - On shutdown.

For 1 & 2, this should be easy, not sure about 3.

An important feature of this, is to allow include / exclude paths to accept / ignore warnings. Eg: if a warning came from a third party library, there's sometimes little one can do, and we should ignore it. If warning came from the code being tested, it should surface.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.