exercism / exercism/php

Namespaces and PSR-4 compliance

オープン
#283 コメント 16 件 リアクション 2 件 担当者 0 名 GitHub で見る
主要言語
PHP
スター
167
フォーク
150
平均マージ
3日 6時間
マージ済み PR(30日)
2

説明

One of the points I am missing in the exercises of this track is the concept of namespaces (PSR-4 compatibility). Therefore, I would like to discuss and propose the following change.

### Suggestion

Each exercise separates actual business logic from tests by having separate `src` and `test` directories. The `README.md` stays in the exercise's root folder. The example solution (and coming stub file) are going into `src` and the test file into `test`.

> The terminating class name corresponds to a file name ending in .php. The file name MUST match the case of the terminating class name.

Since there is no definition for declaration of functions pertaining to the filename, two possible solutions are crossing my mind. Either name the file `functions.php` or `exercise-name.php` - both residing within the exercise's namespace. Here I am interested in suggestions, since I haven't used a file collecting various functions in years.

### Example

Taking Bob as an example, this would result in the following structure:

- `/src` → namespace `Exercism\Bob`
- `Bob.php` (stub file)
- `example.php` (example solution)
- `/test` → namespace `ExercismTest\Bob`
- `BobTest.php`
- `README.md`

### Looking for feedback

My intention is to provide an even greater learning experience for the student within a modern (meaning current) environment.

It would be great to get some feedback on the suggestion over all and possible side effects I might not have fully considered yet (like implications on test automation etc.). Thank you!

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。