exercism / exercism/javascript-analyzer

Improve resistor-color-duo: map to math

Aperta
#51 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
16
Fork
21
Merge medio
6h 53m
PR unite (30g)
2

Descrizione

**Describe the improvement**:

When an _optimal `map`_ solution is provided, the analyzer should `approve` but provide a comment that allows them to _continue_ the path.

```
Perhaps there is a solution that does not involve type-juggling: the act of creating a
_string_ of numbers (the digits) and then parsing it back into a number. For example:
what _value_ does the `4` in the number `42` hold.

You may continue with the next exercise, or try out submitting a more math-y solution
and continue here.
```

**Which exercise**

`resistor-color-duo`

**Additional context**

The `ResistorColorDuoAnalyzer` has a method that checks if an exercise _is optimal_. There are various ways to branch based on that optimality. As per the commentary above, using a `map` is _approvable_ but not _optimal_.

- [`ResistorColorDuoSolution::Entry#isOptimal`](https://github.com/exercism/javascript-analyzer/blob/master/src/analyzers/resistor-color-duo/ResistorColorDuoSolution.ts#L278-L312)
- [`ResistorColorDuoAnalyzer#checkForTips`](https://github.com/exercism/javascript-analyzer/blob/master/src/analyzers/resistor-color-duo/index.ts#L268)

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.