exercism / exercism/javascript-analyzer

Improve resistor-color-duo: map to math

Abierto
#51 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
TypeScript
Estrellas
16
Forks
21
Merge medio
6 h 53 min
PR fusionados (30 d)
2

Descripción

**Describe the improvement**:

When an _optimal `map`_ solution is provided, the analyzer should `approve` but provide a comment that allows them to _continue_ the path.

```
Perhaps there is a solution that does not involve type-juggling: the act of creating a
_string_ of numbers (the digits) and then parsing it back into a number. For example:
what _value_ does the `4` in the number `42` hold.

You may continue with the next exercise, or try out submitting a more math-y solution
and continue here.
```

**Which exercise**

`resistor-color-duo`

**Additional context**

The `ResistorColorDuoAnalyzer` has a method that checks if an exercise _is optimal_. There are various ways to branch based on that optimality. As per the commentary above, using a `map` is _approvable_ but not _optimal_.

- [`ResistorColorDuoSolution::Entry#isOptimal`](https://github.com/exercism/javascript-analyzer/blob/master/src/analyzers/resistor-color-duo/ResistorColorDuoSolution.ts#L278-L312)
- [`ResistorColorDuoAnalyzer#checkForTips`](https://github.com/exercism/javascript-analyzer/blob/master/src/analyzers/resistor-color-duo/index.ts#L268)

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.