exercism / exercism/javascript-analyzer

Incorrect Analysis: JavaScript analyzer makes little sense when a object literal is used

未关闭
#127 19 条评论 0 个 reaction 已指派 1 人 已被 @Steffe-Dev 认领 在 GitHub 查看
good first issue help wanted x:action/improve x:knowledge/elementary x:module/analyzer x:size/small x:type/coding
主要语言
TypeScript
星标
16
派生
21
平均合并
6 小时 53 分钟
30 天内合并 PR
2

描述

**Describe the incorrectness**

I don't think the analyzers advice makes any sense here:

> Using a helper method is good practice, because it replaces a cryptic "member call" with a named call that can be documented individually.

The advice *assumes* a student is using an array - in which case there is complexity to hide and I agree a function as a named abstraction is useful, but in this case a well-named lookup table is serving the same purpose as a function, so the advice makes little sense.

**Which exercise**

Resistor Duo

**Source file(s)**

```js
export const decodedValue = (colors) => {
const resistorBands = {
black: 0,
brown: 1,
// ...
grey: 8,
white: 9
}
return resistorBands[colors[0]]*10 + resistorBands[colors[1]];

};
```

**Expected analysis**

None. (well at least not on this point)

- You could recommend destructuring of the arguments of course - which I would as a mentor.
- Hoisting the constant to a global.

**Additional context**

None.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。