exercism / exercism/javascript-analyzer

Incorrect Analysis: JavaScript analyzer makes little sense when a object literal is used

Abierto
#127 19 comentarios 0 reacciones 1 asignado Reclamado por @Steffe-Dev Ver en GitHub
good first issue help wanted x:action/improve x:knowledge/elementary x:module/analyzer x:size/small x:type/coding
Lenguaje dominante
TypeScript
Estrellas
16
Forks
21
Merge medio
6 h 53 min
PR fusionados (30 d)
2

Descripción

**Describe the incorrectness**

I don't think the analyzers advice makes any sense here:

> Using a helper method is good practice, because it replaces a cryptic "member call" with a named call that can be documented individually.

The advice *assumes* a student is using an array - in which case there is complexity to hide and I agree a function as a named abstraction is useful, but in this case a well-named lookup table is serving the same purpose as a function, so the advice makes little sense.

**Which exercise**

Resistor Duo

**Source file(s)**

```js
export const decodedValue = (colors) => {
const resistorBands = {
black: 0,
brown: 1,
// ...
grey: 8,
white: 9
}
return resistorBands[colors[0]]*10 + resistorBands[colors[1]];

};
```

**Expected analysis**

None. (well at least not on this point)

- You could recommend destructuring of the arguments of course - which I would as a mentor.
- Hoisting the constant to a global.

**Additional context**

None.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.