exercism / exercism/dart

CI formatting check

オープン
#591 コメント 2 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
Dart
スター
60
フォーク
97
PR マージ指標
30日以内にマージされた PR はありません

説明

Currently, https://github.com/exercism/dart/blob/main/.github/workflows/test.yml checks the formatting before running the test suite, potentially failing before the test suite is checked. This should instead be done as a separate GH action.

Any of the three dart files (stub, test suite, or example solution) could be formatted incorrectly so it's unclear which file is the issue from the CI logs. The GH action should specify if possible which file was reformatted and ideally what the change is. `dart format` can show the formatted code for the changed file so perhaps we can compare the formatted code to the original file and display the difference. Surfacing that difference should reduce confusion since we're using dart format with an override for line length. I ran afoul of that early on since locally `dart format` was working fine as far as I could tell.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。