exercism / exercism/cpp

doctor-data task 4 "get_older_bob" is confusing

未关闭
#878 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
C++
星标
290
派生
244
PR 合并指标
30 天内没有已合并 PR

描述

I think in this case either the test case is to simple or the function name is misleading.
The test only checks if the function returns the string "Bob".
Out of two Vessels it seems to return the name of the one called "Bob".

The function name suggests that in the case of two Bob Vessels it would return the older one.
As it only returns the name there is no way to check though.

Also what happens when none of the inputs is a Vessel called "Bob"?

With all accessible information the most sensible solution to the task here might be to ignore the inputs and always return "Bob".

I think this function needs more test cases and/or should be ranamed.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。