doctor-data task 4 "get_older_bob" is confusing
- Dominant language
- C++
- Stars
- 290
- Forks
- 244
- PR merge metrics
- No merged PRs in 30d
Description
I think in this case either the test case is to simple or the function name is misleading.
The test only checks if the function returns the string "Bob".
Out of two Vessels it seems to return the name of the one called "Bob".
The function name suggests that in the case of two Bob Vessels it would return the older one.
As it only returns the name there is no way to check though.
Also what happens when none of the inputs is a Vessel called "Bob"?
With all accessible information the most sensible solution to the task here might be to ignore the inputs and always return "Bob".
I think this function needs more test cases and/or should be ranamed.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start with the doctor-data task 4, "get_older_bob," and its existing test that only checks for the string "Bob." Clarify whether the function should identify the older Bob Vessel, add test cases for multiple Bob Vessels and no matching Vessel, or rename the function if that behavior is not intended; the tests should distinguish the chosen behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100