doctor-data task 4 "get_older_bob" is confusing
- Dominant language
- C++
- Stars
- 290
- Forks
- 244
- PR merge metrics
- No merged PRs in 30d
Description
I think in this case either the test case is to simple or the function name is misleading.
The test only checks if the function returns the string "Bob".
Out of two Vessels it seems to return the name of the one called "Bob".
The function name suggests that in the case of two Bob Vessels it would return the older one.
As it only returns the name there is no way to check though.
Also what happens when none of the inputs is a Vessel called "Bob"?
With all accessible information the most sensible solution to the task here might be to ignore the inputs and always return "Bob".
I think this function needs more test cases and/or should be ranamed.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.