evstack / evstack/ev-node

EVM: Set FinalizedHash correctly in `forkChoiceUpdatedV3` call in ExecuteTxs

未关闭
#2,402 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
C:evm T:code-hygiene
主要语言
Go
星标
361
派生
280
平均合并
2 天 14 小时
30 天内合并 PR
10

描述

In https://github.com/rollkit/rollkit/pull/2394, in order to have sequencer restarts work well, we modified the first call to `forkChoiceUpdatedV3` in the `ExecuteTxs` EVM implementation to assign the previous block hash to HeadBlockHash, SafeBlockHash, and FinalizedBlockHash.

We should revisit this and take one or more of the following approaches:
1. Set the FinalizedBlockHash based on the DA Included Height from the Rollkit Store. For the Head and Safe block hashes, use the Rollkit height which should be the same as the reth block height but it might be good to actually sanity check that on startup and set them in engineClient correctly on start.
2. Persist the current versions of head, safe, and finalizedBlockHashes somewhere so on restarts they can be loaded back easily.

The concrete consequences of setting finalizedHash incorrectly are unknown currently but it'll likely be at least an issue in indexers and block explorers showing inconsistent finalized block hashes for a small period of time.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。