evstack / evstack/ev-node

EVM: Set FinalizedHash correctly in `forkChoiceUpdatedV3` call in ExecuteTxs

Offen
#2,402 4 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
C:evm T:code-hygiene
Vorherrschende Sprache
Go
Sterne
361
Forks
280
Ø Merge
2 T. 14 Std.
Gemergte PRs (30 T.)
10

Beschreibung

In https://github.com/rollkit/rollkit/pull/2394, in order to have sequencer restarts work well, we modified the first call to `forkChoiceUpdatedV3` in the `ExecuteTxs` EVM implementation to assign the previous block hash to HeadBlockHash, SafeBlockHash, and FinalizedBlockHash.

We should revisit this and take one or more of the following approaches:
1. Set the FinalizedBlockHash based on the DA Included Height from the Rollkit Store. For the Head and Safe block hashes, use the Rollkit height which should be the same as the reth block height but it might be good to actually sanity check that on startup and set them in engineClient correctly on start.
2. Persist the current versions of head, safe, and finalizedBlockHashes somewhere so on restarts they can be loaded back easily.

The concrete consequences of setting finalizedHash incorrectly are unknown currently but it'll likely be at least an issue in indexers and block explorers showing inconsistent finalized block hashes for a small period of time.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.