erlef / erlef/elixir-secure-coding

Confusing code example in Section 5: Untrusted Code

Aberta
#39 1 comentário 0 reações 0 responsáveis Ver no GitHub
bug small adjustment
Linguagem predominante
Elixir
Estrelas
731
Forks
172
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

In Section 5: Untrusted Code there's this example that is suggested to be insecure:

```elixir
name = Kino.Input.text("What's your name?")
```

```elixir
textfield_value = Kino.Input.read(name)
{result, binding} = Code.eval_string("a", a: textfield_value)
"Hello, " <> result
```

We did this security training at my small team at work and none of us could figure out how to choose an input that would prove that this code is insecure. See screenshot for example. Is it possible that this example is not correct? Was it supposed to say `Code.eval_string(textfield_value)` instead? That would definitely be insecure.

![Screenshot 2022-11-29 at 15 35 21](https://user-images.githubusercontent.com/7852553/204557541-48b9be12-cfda-4713-afd8-7a434ecc9b82.png)

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.