erlef / erlef/elixir-secure-coding

Confusing code example in Section 5: Untrusted Code

Offen
#39 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug small adjustment
Vorherrschende Sprache
Elixir
Sterne
731
Forks
172
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

In Section 5: Untrusted Code there's this example that is suggested to be insecure:

```elixir
name = Kino.Input.text("What's your name?")
```

```elixir
textfield_value = Kino.Input.read(name)
{result, binding} = Code.eval_string("a", a: textfield_value)
"Hello, " <> result
```

We did this security training at my small team at work and none of us could figure out how to choose an input that would prove that this code is insecure. See screenshot for example. Is it possible that this example is not correct? Was it supposed to say `Code.eval_string(textfield_value)` instead? That would definitely be insecure.

![Screenshot 2022-11-29 at 15 35 21](https://user-images.githubusercontent.com/7852553/204557541-48b9be12-cfda-4713-afd8-7a434ecc9b82.png)

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.