envoyproxy / envoyproxy/ratelimit

Proposal: flag to use tags instead of metric names to distinguish rate limit configs

Đang mở
#162 3 bình luận 3 reaction 0 người được giao Xem trên GitHub
help wanted
Ngôn ngữ chính
Go
Star
2.7k
Fork
535
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

Checking in here before sending out code for this.

The proposal is to add a setting like 'STATS_WITH_TAGS' that changes from reporting config stats like:

`ratelimit.service.rate_limit.._..total_hits`
`ratelimit.service.rate_limit...total_hits`

To something more like:

`ratelimit.service.rate_limit.total_hits config=._.`
`ratelimit.service.rate_limit.total_hits config=.._.`

The non-tagged stats would be deprecated, and on a long-term timeframe maybe the stats reporting would migrate away from the gostats library to the opentelemetry library when it's considered sufficiently mature.

Motivations:
- Some (all?...) dashboard systems make it easier to do aggregation over tags vs over metrics. For example, today both `ratelimit.service.rate_limit..over_limit` and `ratelimit.service.rate_limit..over_limit_with_cache` are metric names, and the dashboarding system I'm working with seems to have inflexible aggregration + globbing so that there doesn't seem to be a way to make a graph including the "over_limit" that doesn't also include the "over_limit_with_cache"
- statsd doesn't have an official protocol and implementations are not all compatible, so moving away from it as a default over time toward supporting protocols real standards feels sensible. Some people will also probably want to ingest into places like Prometheus where stats are more expressive than statsd and can report descriptions of what the metrics are.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.