envoyproxy / envoyproxy/java-control-plane

duplicated opentelemetry packages

未关闭
#342 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Java
星标
312
派生
149
PR 合并指标
30 天内没有已合并 PR

描述

**Problem**
It looks like java-control-plane [replicates](https://github.com/envoyproxy/java-control-plane/tree/main/api/src/main/proto) [opentelemetry-proto-java](https://github.com/open-telemetry/opentelemetry-proto-java) without relocating the dependencies (i.e. you folks use the same package and class names). This duplicates the classes such that now that we've added the `io.envoyproxy.controlplane` dependency to a core library, maven's dependency:analyze tool is forcing us to import `io.envoyproxy.controlplane` in modules that do not interact with controlplane code at all. In a few places, we were forced to replace the opentelemetry import with envoyproxy.controlplane. Our (pruned) jdeps output reveals this issue:

```
jdeps -verbose --class-path ~/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar path/to/now_requires_controlplane_import.jar | grep 'api-1.0.41.jar'

now_requires_controlplane_import.jar -> /Users/joy.bestourous/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar
-> io.opentelemetry.proto.common.v1.AnyValue api-1.0.41.jar
...
```

**Solution Requested**
We're hoping you folks could either depend directly on opentelemetry-proto or use a different package to avoid this duplication and subsequent maven confusion.

Thanks in advance!

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。