envoyproxy / envoyproxy/java-control-plane

duplicated opentelemetry packages

Abierto
#342 1 comentario 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Java
Estrellas
312
Forks
149
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Problem**
It looks like java-control-plane [replicates](https://github.com/envoyproxy/java-control-plane/tree/main/api/src/main/proto) [opentelemetry-proto-java](https://github.com/open-telemetry/opentelemetry-proto-java) without relocating the dependencies (i.e. you folks use the same package and class names). This duplicates the classes such that now that we've added the `io.envoyproxy.controlplane` dependency to a core library, maven's dependency:analyze tool is forcing us to import `io.envoyproxy.controlplane` in modules that do not interact with controlplane code at all. In a few places, we were forced to replace the opentelemetry import with envoyproxy.controlplane. Our (pruned) jdeps output reveals this issue:

```
jdeps -verbose --class-path ~/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar path/to/now_requires_controlplane_import.jar | grep 'api-1.0.41.jar'

now_requires_controlplane_import.jar -> /Users/joy.bestourous/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar
-> io.opentelemetry.proto.common.v1.AnyValue api-1.0.41.jar
...
```

**Solution Requested**
We're hoping you folks could either depend directly on opentelemetry-proto or use a different package to avoid this duplication and subsequent maven confusion.

Thanks in advance!

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.