envoyproxy / envoyproxy/java-control-plane

duplicated opentelemetry packages

Open
#342 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
312
Forks
149
PR merge metrics
No merged PRs in 30d

Description

**Problem**
It looks like java-control-plane [replicates](https://github.com/envoyproxy/java-control-plane/tree/main/api/src/main/proto) [opentelemetry-proto-java](https://github.com/open-telemetry/opentelemetry-proto-java) without relocating the dependencies (i.e. you folks use the same package and class names). This duplicates the classes such that now that we've added the `io.envoyproxy.controlplane` dependency to a core library, maven's dependency:analyze tool is forcing us to import `io.envoyproxy.controlplane` in modules that do not interact with controlplane code at all. In a few places, we were forced to replace the opentelemetry import with envoyproxy.controlplane. Our (pruned) jdeps output reveals this issue:

```
jdeps -verbose --class-path ~/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar path/to/now_requires_controlplane_import.jar | grep 'api-1.0.41.jar'

now_requires_controlplane_import.jar -> /Users/joy.bestourous/.m2/repository/io/envoyproxy/controlplane/api/1.0.41/api-1.0.41.jar
-> io.opentelemetry.proto.common.v1.AnyValue api-1.0.41.jar
...
```

**Solution Requested**
We're hoping you folks could either depend directly on opentelemetry-proto or use a different package to avoid this duplication and subsequent maven confusion.

Thanks in advance!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.