envoyproxy / envoyproxy/gateway

Support for disabling xff header append

オープン
#4,233 コメント 8 件 リアクション 4 件 担当者 1 名 @rudrakhp に割り当て済み GitHub で見る
stale
主要言語
Go
スター
3k
フォーク
864
平均マージ
2日 2時間
マージ済み PR(30日)
140

説明

EG by default sets [use-remote-address](https://www.envoyproxy.io/docs/envoy/latest/api-v3/extensions/filters/network/http_connection_manager/v3/http_connection_manager.proto#envoy-v3-api-field-extensions-filters-network-http-connection-manager-v3-httpconnectionmanager-use-remote-address) to `true` currently at
https://github.com/envoyproxy/gateway/blob/14f687fb4fd18b98de654d22119f4e4bd10a71e2/internal/xds/translator/listener.go#L242
while in envoy this is `false` by default. My understanding is that as eg is supposed to be the first L7 layer for downstream traffic, hence this has been set to `true`.

However in our use case eg is not the first L7 layer, rather its aws ALB due to which ALB private ip gets appended to xff header which we don't want. Hence we want this to be `false` or an option to set `skip_xff_append` to `true`. So it would be nice to have an api to set above two fields.

For anyone else facing the same issue for now you can use below `jsonPatch` in `EnvoyPatchPolicy`:
```yaml
jsonPatches:
- type: "type.googleapis.com/envoy.config.listener.v3.Listener"
# The listener name is of the form //
name: staging/eg-staging/http
operation:
op: add
path: "/default_filter_chain/filters/0/typed_config/skip_xff_append"
value: true
```

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。