envoyproxy / envoyproxy/gateway

egctl x translate should be able to process multiple gatewayclasses

未关闭
#3,207 4 条评论 0 个 reaction 已指派 1 人 已被 @shawnh2 认领 在 GitHub 查看
area/egctl area/provider area/standalone kind/refactor stale
主要语言
Go
星标
3k
派生
864
平均合并
2 天 2 小时
30 天内合并 PR
140

描述

*Description*:

For now, the `kubernetesYAMLToResources` function in `egctl x translate` only able to process one GatewayClass, for multiple GC case, the translation will fail.

https://github.com/envoyproxy/gateway/blob/c0068a056f225e136a740823d6d0955cf380374e/internal/cmd/egctl/translate.go#L628

IMO, above function should return something like:

```go
type LoadResources struct {
Resources

GatewayClasses []*gwv1.GatewayClass
EnvoyProxies []*egv1a1.EnvoyProxy
}
```

- The GC and EP should be stored in list instead of variable
- Above function should be placed in gatewayapi layer (This will be super helpful for file-provider in standalone mode to reuse this logic to load all kinds of resources from file)

Any thoughts on this? cc @envoyproxy/gateway-maintainers

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。