envoyproxy / envoyproxy/gateway

egctl x translate should be able to process multiple gatewayclasses

Aperta
#3,207 4 commenti 0 reazioni 1 assegnatario Rivendicata da @shawnh2 Vedi su GitHub
area/egctl area/provider area/standalone kind/refactor stale
Lingua principale
Go
Stelle
3k
Fork
864
Merge medio
2g 2h
PR unite (30g)
140

Descrizione

*Description*:

For now, the `kubernetesYAMLToResources` function in `egctl x translate` only able to process one GatewayClass, for multiple GC case, the translation will fail.

https://github.com/envoyproxy/gateway/blob/c0068a056f225e136a740823d6d0955cf380374e/internal/cmd/egctl/translate.go#L628

IMO, above function should return something like:

```go
type LoadResources struct {
Resources

GatewayClasses []*gwv1.GatewayClass
EnvoyProxies []*egv1a1.EnvoyProxy
}
```

- The GC and EP should be stored in list instead of variable
- Above function should be placed in gatewayapi layer (This will be super helpful for file-provider in standalone mode to reuse this logic to load all kinds of resources from file)

Any thoughts on this? cc @envoyproxy/gateway-maintainers

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.