ember-learn / ember-learn/ember-cli-addon-docs

Styles don't play nice with disabled application-template-wrapper

Aperta
#422 6 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
172
Fork
142
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

When using addon-docs on an app with `application-template-wrapper` set to `false` (which is default in octane), the app styles don't work well. See below:

https://github.com/ember-learn/ember-cli-addon-docs/blob/75742729ec9443e653ad9383c0fbdafb1b404ef0/addon/styles/addon.scss#L51-L58

Screen Shot 2019-11-01 at 3 02 55 PM

This is simple to fix, but it would be better to not break for these cases.
The fix is just wrapping the content of application.hbs with a `div` with classes `ember-view`:

```hbs


{{outlet}}


```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.