ember-learn / ember-learn/ember-cli-addon-docs
Styles don't play nice with disabled application-template-wrapper
Open
- Dominant language
- JavaScript
- Stars
- 172
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
When using addon-docs on an app with `application-template-wrapper` set to `false` (which is default in octane), the app styles don't work well. See below:
https://github.com/ember-learn/ember-cli-addon-docs/blob/75742729ec9443e653ad9383c0fbdafb1b404ef0/addon/styles/addon.scss#L51-L58
This is simple to fix, but it would be better to not break for these cases.
The fix is just wrapping the content of application.hbs with a `div` with classes `ember-view`:
```hbs
{{outlet}}
```
Contributor guide
Assessment
This issue has not been assessed yet.