ember-learn / ember-learn/ember-cli-addon-docs
Clean up `name` argument usage in docs-demo component
Aperta
- Lingua principale
- JavaScript
- Stelle
- 172
- Fork
- 142
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
Couple of issues I'm having with the `name` argument for the docs-demo:
1. I get `Attempted to register a view with an id already in use: example-undefined` a lot, because I forget to add a name. If a name is required, we should assert that it exists when the component is rendered.
2. It seems very verbose to require a name, and then (generally) require each snippet to set its names as well. Could we use the `name` argument to infer the snippets for the demo? Possibly allowing us to just pass in `type` to each snippet?
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.