ember-learn / ember-learn/ember-cli-addon-docs
Clean up `name` argument usage in docs-demo component
Offen
- Vorherrschende Sprache
- JavaScript
- Sterne
- 172
- Forks
- 142
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
Couple of issues I'm having with the `name` argument for the docs-demo:
1. I get `Attempted to register a view with an id already in use: example-undefined` a lot, because I forget to add a name. If a name is required, we should assert that it exists when the component is rendered.
2. It seems very verbose to require a name, and then (generally) require each snippet to set its names as well. Could we use the `name` argument to infer the snippets for the demo? Possibly allowing us to just pass in `type` to each snippet?
Beitragsleitfaden
Bewertung
Dieses Issue wurde noch nicht bewertet.