ember-cli / ember-cli/ember-cli-update

Pick up npm config for alternative npm registries, custom ca, etc.

オープン
#1,260 コメント 3 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
279
フォーク
44
PR マージ指標
30日以内にマージされた PR はありません

説明

Unfortunately `embrer-cli-update` won't work in environments that rely on customising the npm registry.
I feel Ember is a good option for enterprises, which are often in this situation of using an internal mirror registry. It would be great to smooth the Ember upgrade experience by being able to use this tool.

Two issues here:
* using wrong registry
* not picking up custom CA certs

```
❯ ember-cli-update --to 4.12
FetchError: request to https://registry.npmjs.org/ember-cli failed, reason: self-signed certificate in certificate chain
at ClientRequest. (//node_modules/ember-cli-update/node_modules/minipass-fetch/lib/index.js:130:14)
at ClientRequest.emit (node:events:517:28)
at TLSSocket.socketErrorListener (node:_http_client:501:9)
at TLSSocket.emit (node:events:517:28)
at emitErrorNT (node:internal/streams/destroy:151:8)
at emitErrorCloseNT (node:internal/streams/destroy:116:3)
at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
code: 'SELF_SIGNED_CERT_IN_CHAIN',
errno: 'SELF_SIGNED_CERT_IN_CHAIN',
type: 'system'
}
```

I assume the best way for this tool to work is that it is aware of npm config, however that is passed to npm. (env, flags, npmrc)

## Hacky solution

I have cobbled together a solution that uses [npm-conf](https://github.com/kevva/npm-conf) to grab the npm configuration and pass it into the various [pacote](https://github.com/npm/pacote?tab=readme-ov-file#options) methods' opts param.

In `boilerplate-update` I also modified these functions to take an `opts` arg to pass to pacote:
`downloadAndCheckForUpdates` `getApplicableCodemods` `getCodemods` `getVersions`.

It sort of works, but doesn't feel like the most elegant design.

## Considering something more ideal

It would be nice if `pacote` could be configured to pick up npm config out of the box.

Maybe, as an interim, `pacote` could be wrapped/proxied within `boilerplate-update` to pick up npm config when necessary. Expose that same proxy for `ember-cli-update` to make use of. This should require less changes to the various method signatures within `ember-cli-update` and `boilerplate-update`

Then there's [npm-conf](https://github.com/kevva/npm-conf) not npm official, and not well maintained, but has significant use.
To me, this still feels hacky, and really there should be some module `npm` relies on that we can also rely on for picking up npm config.

What do you reckon @kellyselden? Is there a better approach you're aware of?

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

まず、ember-cli-update と boilerplate-update がどのように pacote を呼び出しているかを追跡し、downloadAndCheckForUpdates、getApplicableCodemods、getCodemods、getVersions に焦点を当てます。提案されている npm-conf のアプローチと pacote のオプションを比較し、そのうえで一貫した設定経路を定義します。分散した opts の変更を必要とせず、代替レジストリとカスタム CA 証明書が尊重されれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
javascript
領域
cli, tooling
issue の種類
機能追加
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
38/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。