ember-cli / ember-cli/ember-cli-clean-css

Passing clean-css options doesn't work

Đang mở
#306 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
Ngôn ngữ chính
JavaScript
Star
6
Fork
5
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

We recently updated all the packages and dependencies in our Ember.js project to their latest versions. Since then when this project is built with the `--environment production` flag, the CSS looks broken when browsing through its web pages. Disabling the CSS minifying fixes the issue.

I am trying to investigate and find out which CSS optimization is breaking our CSS styles, but it doesn't look like passing custom `clean-css` options is working correctly:

`enabled` works:
```
minifyCSS: {
enabled: true // or false
}
```

`level (integer)` works:
```
minifyCSS: {
options: {
level: 1 // 0, 1 or 2
}
}
```

`level (with options)` doesn't work:
```
minifyCSS: {
options: {
level: {
1: {
all: false,
optimizeFont: true
},
2: {
all: false
}
}
}
}
```

Passing the last `options` above does not have the desired result, which would be to only have `optimizeFont` enabled and all other optimizations disabled. The final CSS minifying looks the same as if everything was enabled.

The `clean-css` documentation says that we should be able to individually enable or disable each optimization (https://github.com/clean-css/clean-css?tab=readme-ov-file#level-0-optimizations) but I haven't encountered a single example of such a thing being done in Ember.js or in `ember-cli-clean-css`.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.