ember-cli / ember-cli/babel-plugin-ember-modules-api-polyfill

Handle wildcard imports: import * as something from '@ember/something'

オープン
#16 コメント 1 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
JavaScript
スター
15
フォーク
19
PR マージ指標
30日以内にマージされた PR はありません

説明

https://github.com/babel/ember-cli-babel/issues/170#issue-246272427

> The [`import` statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import) supports importing all named exports into an object.
>
>For example, instead of this
>
>```js
>import {
> alias as computedAlias,
> and as computedAnd,
> // ...
>} from '@ember/object/computed';
>import { decoratedPropertyWithRequiredParams } from '../utils/decorator-macros';
>
>export const alias = decoratedPropertyWithRequiredParams(computedAlias);
>```
>
> you could just do this
>
> ```js
> import * as computed from '@ember/object/computed';
> import { decoratedPropertyWithRequiredParams } from '../utils/decorator-macros';
>
> export const alias = decoratedPropertyWithRequiredParams(computed.alias);
> ```
>
> But apparently, the latter does not work. :slightly_frowning_face:
>
> ```
> Could not find module `@ember/object/computed` imported from `ember-decorators/object/computed`
> ```

https://github.com/babel/ember-cli-babel/issues/170#issuecomment-318635180
> We would need to handle wildcard import in babel-plugin-ember-modules-API-polyfill. This seems reasonable to me though. We would need to check if the specified module contains only exports from a single namespace or multiple. If multiple namespaces we would have to build up the intermediate POJO that would be used.

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。