elementary / elementary/code

"Save Duplicate" button does not work after unmounting source device

Open
#1,818 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Vala
Stars
521
Forks
118
Avg merge
1d 8h
Merged PRs (30d)
14

Description

### What Happened?

While operating Code with "Save files when changed" preference off, a document was loaded from an unmountable source (USB stick). Some changes were made and then the source device unmounted before saving. Code showed a dialog with "Ignore" and "Save Duplicate" buttons. Pressing the latter just resulted in the dialog being shown again.

The only way to save the changes was to duplicate the tab into a new document and save that.

### Steps to Reproduce

1. Turn off "Save files when changed"
2. Open a document on an unmountable device
3. Make some changes
4. Unmount the device
5. Observe dialog and effect of pressing "Save Duplicate"

### Expected Behavior

Pressing "Save Duplicate" allows the changed document to be saved elsewhere.

### OS Version

8.x (Circe)

### OS Architecture

amd64 (on most hardwares)

### Session Type

Secure Session (Wayland, This is the default)

### Software Version

Latest Release

### Log Output

```shell
** (io.elementary.code:5576): WARNING **: 10:44:40.136: Document.vala:1356: Folder containing the file was unmounted

** (io.elementary.code:5576): CRITICAL **: 10:46:40.346: scratch_services_document_save_as_co: assertion '!locked && is_saving' failed
```

### Hardware Info

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.