element-hq / element-hq/element-ios

Create a root coordinator per legacy screen flows

Ouverte
#3,597 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
A-Developer-Experience A-Navigation
Langage dominant
Swift
Étoiles
1.8k
Forks
544
Métriques de merge des PR
Métriques de PR en attente

Description

At the beginning we can create several root coordinators to handle screen flows in ObjC. Navigation between detail screens in these flows can be called from view controllers directly but the root view controllers should delegate navigation to the coordinator. We can create a root coordinator for:
- [x] split view
- [ ] tab bar: `TabBarCoordinator` exists,
- [ ] continue to migrate navigation code from `TabBarController` to `TabBarCoordinator`
- [ ] remove navigation to authentication, settings and so on when they are migrated to coordinator. They should be managed from other places.
- [ ] Unified search
- [ ] RoomViewController presentation (`showRoomDetails`)
- [ ] Contact details (`showContactDetails`)
- [ ] Show group detail (`showGroupDetails`)
- [ ] Show settings
- [ ] every root view controller from the tab bar
- [ ] home
- [ ] favorites
- [ ] people
- [ ] rooms
- [ ] groups
- [ ] settings
- [ ] room, look at Tchap [RoomCoordinator](https://github.com/dinsic-pim/tchap-ios/blob/develop/Tchap/Modules/Room/RoomCoordinator.swift)
- [ ] room settings
- [ ] authentication
...

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.