element-hq / element-hq/element-ios

Create a root coordinator per legacy screen flows

Offen
#3,597 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
A-Developer-Experience A-Navigation
Vorherrschende Sprache
Swift
Sterne
1.8k
Forks
544
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

At the beginning we can create several root coordinators to handle screen flows in ObjC. Navigation between detail screens in these flows can be called from view controllers directly but the root view controllers should delegate navigation to the coordinator. We can create a root coordinator for:
- [x] split view
- [ ] tab bar: `TabBarCoordinator` exists,
- [ ] continue to migrate navigation code from `TabBarController` to `TabBarCoordinator`
- [ ] remove navigation to authentication, settings and so on when they are migrated to coordinator. They should be managed from other places.
- [ ] Unified search
- [ ] RoomViewController presentation (`showRoomDetails`)
- [ ] Contact details (`showContactDetails`)
- [ ] Show group detail (`showGroupDetails`)
- [ ] Show settings
- [ ] every root view controller from the tab bar
- [ ] home
- [ ] favorites
- [ ] people
- [ ] rooms
- [ ] groups
- [ ] settings
- [ ] room, look at Tchap [RoomCoordinator](https://github.com/dinsic-pim/tchap-ios/blob/develop/Tchap/Modules/Room/RoomCoordinator.swift)
- [ ] room settings
- [ ] authentication
...

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.