elastic / elastic/apm-agent-python
[CI] BDD Tests that are not implemented: should the build fail or warn?
- 主要语言
- Python
- 星标
- 431
- 派生
- 239
- 平均合并
- 5 天 10 小时
- 30 天内合并 PR
- 7
描述
We noticed that there are a few BDD files under https://github.com/elastic/apm-agent-python/tree/master/tests/bdd/features
- api_key
- azure_app_service_metadata
- outcome
But only the API Key ones are implemented.
>[2021-08-02T10:01:23.365Z] tests/bdd/__init__.py 0 0 0 0 100%
[2021-08-02T10:01:23.365Z] tests/bdd/api_key_tests.py 31 15 0 0 52%
[2021-08-02T10:01:23.365Z] tests/client/__init__.py 0 0 0 0 100%
You can check that they do not appear under the test list for that package: https://apm-ci.elastic.co/job/apm-agent-python/job/apm-agent-python-mbp/job/master/500/testReport/tests.bdd/
I'd like to ask about your expectations on it: should the build fail because they are not implemented, or show them as skipped?
贡献指南
调研方向
首先检查 tests/bdd/features 下与 api_key、azure_app_service_metadata 和 outcome 对应的 BDD 文件,然后将其与 tests/bdd/api_key_tests.py 以及链接的 CI 测试报告进行比较。在确定实现范围之前,该 issue 需要针对未实现场景制定一致同意的策略;当所选择的 fail-or-skip 行为明确,并且在 CI 中得到一致体现时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- ci-cd, testing
- Issue 类型
- 功能
- 难度
- 5/5
- 预计耗时
- 一周以上
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 25/100