elastic / elastic/apm-agent-python

[CI] BDD Tests that are not implemented: should the build fail or warn?

Ouverte
#1,201 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
agent-python question
Langage dominant
Python
Étoiles
431
Forks
239
Merge moyen
5 j 10 h
PR mergées (30 j)
7

Description

We noticed that there are a few BDD files under https://github.com/elastic/apm-agent-python/tree/master/tests/bdd/features
- api_key
- azure_app_service_metadata
- outcome

But only the API Key ones are implemented.

>[2021-08-02T10:01:23.365Z] tests/bdd/__init__.py 0 0 0 0 100%
[2021-08-02T10:01:23.365Z] tests/bdd/api_key_tests.py 31 15 0 0 52%
[2021-08-02T10:01:23.365Z] tests/client/__init__.py 0 0 0 0 100%

You can check that they do not appear under the test list for that package: https://apm-ci.elastic.co/job/apm-agent-python/job/apm-agent-python-mbp/job/master/500/testReport/tests.bdd/

I'd like to ask about your expectations on it: should the build fail because they are not implemented, or show them as skipped?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.