eclipse-windowbuilder / eclipse-windowbuilder/windowbuilder

Remove support for the deleted Databinding API

Aperta
#492 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Java
Stelle
97
Fork
34
Merge medio
21h 52m
PR unite (30g)
25

Descrizione

Related to #491. There are several locations where WindowBuilder:

a) Makes several case-distinctions between the old and new Observable API
b) Creates a bi-directional mapping between methods of the new API to the old API

Keeping the former is a real pain in terms of maintainability. Latter falls apart because both versions are not 100% compatible.
Example: `SWTObservables.observeSelection()` can be any of `WidgetProperties.widgetSelection()`, `WidgetProperties.dateTimeSelection()`, ...
And this problem will only increase, the more features are added to the new API.

Given that the old API is gone for good, I don't think it makes any sense for WindowBuilder to keep referencing it internally or even generate code for it.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.