eclipse-windowbuilder / eclipse-windowbuilder/windowbuilder

Remove support for the deleted Databinding API

Offen
#492 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
Java
Sterne
97
Forks
34
Ø Merge
21 Std. 52 Min.
Gemergte PRs (30 T.)
25

Beschreibung

Related to #491. There are several locations where WindowBuilder:

a) Makes several case-distinctions between the old and new Observable API
b) Creates a bi-directional mapping between methods of the new API to the old API

Keeping the former is a real pain in terms of maintainability. Latter falls apart because both versions are not 100% compatible.
Example: `SWTObservables.observeSelection()` can be any of `WidgetProperties.widgetSelection()`, `WidgetProperties.dateTimeSelection()`, ...
And this problem will only increase, the more features are added to the new API.

Given that the old API is gone for good, I don't think it makes any sense for WindowBuilder to keep referencing it internally or even generate code for it.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.